On Thu, 20 Sep 2018 at 15:12, Mathias Fröhlich
<mathias.froehl...@gmx.net> wrote:
>
> Hi Emil,
>
> Some comments inline below:
>
> On Tuesday, 4 September 2018 20:32:59 CEST Emil Velikov wrote:
> > From: Emil Velikov <emil.veli...@collabora.com>
> >
> > Add a plain software device, which is always available.
> >
> > We can safely assign it as the first/initial device in _eglGlobals,
> > although we ensure that's the case with a handful of _eglDeviceSupports
> > checks throughout the code.
> >
> > v2:
> > - s/_eglFindDevice/_eglAddDevice/ (Eric)
> > - s/_eglLookupAllDevices/_eglRefreshDeviceList/ (Eric)
> > - move ^^ helpers into a earlier patch (Eric, Mathias)
> > - set the SW device on _eglGlobal init. (Eric)
> > - add a number of _eglDeviceSupports checks (Mathias)
> > - split Device/Display attach to a separate patch
> >
> > Signed-off-by: Emil Velikov <emil.veli...@collabora.com>
> > ---
> > src/egl/main/egldevice.c | 27 +++++++++++++++++++++++++++
> > src/egl/main/egldevice.h | 4 +++-
> > src/egl/main/eglglobals.c | 1 +
> > 3 files changed, 31 insertions(+), 1 deletion(-)
> >
> > diff --git a/src/egl/main/egldevice.c b/src/egl/main/egldevice.c
> > index bbc9f2060d1..1d67fd71191 100644
> > --- a/src/egl/main/egldevice.c
> > +++ b/src/egl/main/egldevice.c
> > @@ -37,6 +37,8 @@ struct _egl_device {
> > _EGLDevice *Next;
> >
> > const char *extensions;
> > +
> > + EGLBoolean MESA_device_software;
> > };
> >
> > void
> > @@ -47,6 +49,12 @@ _eglFiniDevice(void)
> > /* atexit function is called with global mutex locked */
> >
> > dev_list = _eglGlobal.DeviceList;
> > +
> > + /* The first device is on-stack allocated SW device */
>
> May be I name that wrong as non native english, but 'on-stack'
> would be something different for me. The stack is more or less
> the function local allocation scope.
>
> The sw device is much more a 'static allocated SW device'.
>
> Right?
>
Sounds better indeed. Will fix shortly.
-Emil
_______________________________________________
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
