On Thu, 20 Sep 2018 at 15:11, Mathias Fröhlich
<mathias.froehl...@gmx.net> wrote:
>
> Hi Emil,
>
Thanks Mathias.
Just coming back from some holidays and XDC. Most of your commends are
addressed ... the ones which are not I'll commend on in a moment.
> On Tuesday, 4 September 2018 20:32:58 CEST Emil Velikov wrote:
> > From: Emil Velikov <emil.veli...@collabora.com>
> >
> > Introduce the API for device query and enumeration. Those at the moment
> > produce nothing useful since zero devices are actually available.
> >
> > That contradicts with the spec, so the extension isn't advertised just
> > yet.
> >
> > With later commits we'll add support for software (always) and hardware
> > devices. Each one exposing the respective extension string.
> >
> > v2:
> > - fold API boilerplate into this patch
> > - move _eglAddDevice, _eglDeviceSupports, _eglRefreshDeviceList to this
> > patch (Eric, Mathias)
> > - make _eglFiniDevice the one called last
>
> Thanks for the updated series.
>
> Nevertheless, patches #1, #2, #3, #8 have comments.
> Especialy there are lots of asserts that either dont compile or assert on
> else working code.
> You should double check what they are supposed to do.
>
Indeed I got my asserts the wrong way around ... at least I was consistent ;-)
> > +static int
> > +_eglRefreshDeviceList(void)
> > +{
> > + _EGLDevice *dev;
> > + int count = 0;
> > +
> > + dev = _eglGlobal.DeviceList;
>
> That one gives a compile warning in release compiles.
>
> Even in the final version of the file past the whole patch series.
> The dev argument is only used in asserts finally.
>
Right, I'll annotate dev as MAYBE_UNUSED.
-Emil
_______________________________________________
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
