On 6 September 2018 at 17:58, Eric Engestrom <eric.engest...@intel.com> wrote: > On Thursday, 2018-09-06 17:43:50 +0300, asimiklit.w...@gmail.com wrote: >> From: Andrii Simiklit <andrii.simik...@globallogic.com> >> >> This patch improve usage of [v][s][n]printf functions. >> Fixes cross platform implementation of vsnprintf >> >> v2: Linux man about vXXXprintf functions: >> "These functions do not call the va_end macro. Because they >> invoke the va_arg macro, the value of ap is undefined after the call" >> So we should have instance copy of va_list for each 'vXXXprintf' call. >> >> v3: Fixed case when malloc returns 0 in util_vasprintf >> >> v4: The single patch was separated to the patch series >> >> Andrii Simiklit (8): >> apple/glx/log: added missing va_end() after va_copy() >> mesa/util: don't use the same 'va_list' instance twice >> mesa/util: don't ignore NULL returned from 'malloc' >> mesa/util: add missing va_end() after va_copy() > > First 4 are > Reviewed-by: Eric Engestrom <eric.engest...@intel.com> > and pushed :) > > Thanks for taking the time to find the right Fixes: btw, that really > helps when backporting to stable branches :) > Small nitpick: "mesa/util" should be just "util". Regardless, patches are spot on. Kudos for all the Fixes tags.
>> mesa/main: don't use win _vsnprintf. there is 'util_vsnprintf' >> function As-is, or reworked to drop the _mesa_ function (as Ian suggested) patch is Reviewed-by: Emil Velikov <emil.veli...@collabora.com> >> mesa/util: use cross platform implementation 'util_vsnprintf' > "mesa/util" -> "util", with that Reviewed-by: Emil Velikov <emil.veli...@collabora.com> >> radv: use cross platform implementation 'util_vsnprintf' >> egl/main: use cross platform implementation 'util_vsnprintf' > > These two are: > Acked-by: Eric Engestrom <eric.engest...@intel.com> > Reviewed-by: Emil Velikov <emil.veli...@collabora.com> Admittedly, I doubt we'll get radv on Windows soon. At least not before we bump the requirement to MSVC2015 which has C99 compliant function. HTH Emil _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
