On Thu, 2018-09-06 at 17:58 +0100, Eric Engestrom wrote: > On Thursday, 2018-09-06 17:43:50 +0300, asimiklit.w...@gmail.com wrote: > > From: Andrii Simiklit <andrii.simik...@globallogic.com> > > > > This patch improve usage of [v][s][n]printf functions. > > Fixes cross platform implementation of vsnprintf > > > > v2: Linux man about vXXXprintf functions: > > "These functions do not call the va_end macro. Because they > > invoke the va_arg macro, the value of ap is undefined after the call" > > So we should have instance copy of va_list for each 'vXXXprintf' call. > > > > v3: Fixed case when malloc returns 0 in util_vasprintf > > > > v4: The single patch was separated to the patch series > > > > Andrii Simiklit (8): > > apple/glx/log: added missing va_end() after va_copy() > > mesa/util: don't use the same 'va_list' instance twice > > mesa/util: don't ignore NULL returned from 'malloc' > > mesa/util: add missing va_end() after va_copy() > > First 4 are > Reviewed-by: Eric Engestrom <eric.engest...@intel.com> > and pushed :) > > Thanks for taking the time to find the right Fixes: btw, that really > helps when backporting to stable branches :)
Indeed ☺ Thanks Andrii for the effort, and Eric for the advice to split and tag with the proper Fixes. -- Br, Andres _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
