On Friday, August 17, 2018 1:06:27 PM PDT Jason Ekstrand wrote: > Previously, the back-end compiler turn image access into magic uniform > reads and there was a complex contract between back-end compiler and > driver about setting up and filling out those params. As of this > commit, both drivers now lower image_deref_load_param_intel intrinsics > to load_uniform intrinsics controlled by the driver and lower the other > image_deref_* intrinsics to image_* intrinsics which take an actual > binding table index. There are still "magic" uniforms but they are now > added and controlled entirely by the driver and that contract no longer > spans components. > > This also has the side-effect of making most image use compile-time > binding table indices. Previously, all image access pulled the binding > table index from a uniform. Part of the reason for this was that the > magic uniforms made it difficult to decouple binding table indices from > the uniforms and, since they are indexed completely differently > (especially in Vulkan), it was hard to pull them apart. Now that the > driver is handling both, it's trivial to decouple the two and provide > actual binding table indices.
Reviewed-by: Kenneth Graunke <kenn...@whitecape.org>
signature.asc
Description: This is a digitally signed message part.
_______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
