Re: [Mesa-dev] [PATCH 1/2] intel/blorp: Fix blits to R8G8B8_UNORM_SRGB

[Samuel Iglesias Gonsálvez]

Assuming Jenkins is happy with them, this series is

Reviewed-by: Samuel Iglesias Gonsálvez <sigles...@igalia.com>

Sam


On 13/07/18 00:48, Jason Ekstrand wrote:
> In this case, the surface faking will give us a R8_UNORM surface and we
> need to do an sRGB conversion in the shader.
>
> cc: mesa-sta...@lists.freedesktop.org
> ---
>  src/intel/blorp/blorp_blit.c | 4 ++++
>  1 file changed, 4 insertions(+)
>
> diff --git a/src/intel/blorp/blorp_blit.c b/src/intel/blorp/blorp_blit.c
> index 0045275a550..66f58344ef6 100644
> --- a/src/intel/blorp/blorp_blit.c
> +++ b/src/intel/blorp/blorp_blit.c
> @@ -1954,6 +1954,10 @@ try_blorp_blit(struct blorp_batch *batch,
>        params->x0 *= 3;
>        params->x1 *= 3;
>  
> +      /* If it happens to be sRGB, we need to force a conversion */
> +      if (params->dst.view.format == ISL_FORMAT_R8G8B8_UNORM_SRGB)
> +         wm_prog_key->dst_format = ISL_FORMAT_R9G9B9E5_SHAREDEXP;
> +
>        surf_fake_rgb_with_red(batch->blorp->isl_dev, &params->dst);
>  
>        wm_prog_key->dst_rgb = true;

signature.asc
Description: OpenPGP digital signature

_______________________________________________
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev