On Wednesday 27 June 2018, Samuel Pitoiset wrote:
>
> On 06/27/2018 02:12 AM, Bas Nieuwenhuizen wrote:
> > Reviewed-by: Bas Nieuwenhuizen <b...@basnieuwenhuizen.nl>
> >
> > for patch 3-4. Not sure they should go to stable though, since they
> > are optimizations?
>
> Isn't the whole series for optimization purposes?
No, patches 2 and 7 are bugfixes. Patch 7 will cause additional flushes
in the meta code paths without patch 6, so that patch is also marked
for stable. Patch 8 is an optimization of patch 7 that I decided to keep
separate for bisectibility.
That being said, these patches don't fix any issues in any real applications
as far as I'm aware.
Patches 1, 3 and 4 are just optimizations, so those should indeed not go
to stable.
> >
> > On Tue, Jun 26, 2018 at 11:49 PM, Fredrik Höglund <fred...@kde.org> wrote:
> >> This is to avoid repeating dependencies when more than one subpass
> >> has a dependency from external.
> >>
> >> Cc: <mesa-sta...@lists.freedesktop.org>
> >> Signed-off-by: Fredrik Höglund <fred...@kde.org>
> >> ---
> >> src/amd/vulkan/radv_pass.c | 4 ++++
> >> 1 file changed, 4 insertions(+)
> >>
> >> diff --git a/src/amd/vulkan/radv_pass.c b/src/amd/vulkan/radv_pass.c
> >> index 2827f5f1a8d..7e6fd84af55 100644
> >> --- a/src/amd/vulkan/radv_pass.c
> >> +++ b/src/amd/vulkan/radv_pass.c
> >> @@ -179,6 +179,10 @@ VkResult radv_CreateRenderPass(
> >> if (src == dst)
> >> continue;
> >>
> >> + if (src == VK_SUBPASS_EXTERNAL) {
> >> + /* Add all dependencies from external to the first
> >> subpass */
> >> + dst = 0;
> >> + }
> >> if (dst == VK_SUBPASS_EXTERNAL) {
> >> if (pCreateInfo->pDependencies[i].dstStageMask !=
> >> VK_PIPELINE_STAGE_BOTTOM_OF_PIPE_BIT)
> >> pass->end_barrier.src_stage_mask |=
> >> pCreateInfo->pDependencies[i].srcStageMask;
> >> --
> >> 2.17.0
> >>
> >> _______________________________________________
> >> mesa-dev mailing list
> >> mesa-dev@lists.freedesktop.org
> >> https://lists.freedesktop.org/mailman/listinfo/mesa-dev
> > _______________________________________________
> > mesa-dev mailing list
> > mesa-dev@lists.freedesktop.org
> > https://lists.freedesktop.org/mailman/listinfo/mesa-dev
> >
>
_______________________________________________
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
