On 03/06/2018 11:24 AM, Matt Turner wrote: > On Tue, Mar 6, 2018 at 11:22 AM, Ian Romanick <i...@freedesktop.org> wrote: >> On 03/05/2018 04:40 PM, Matt Turner wrote: >>> On Fri, Feb 23, 2018 at 3:56 PM, Ian Romanick <i...@freedesktop.org> wrote: >>>> From: Kenneth Graunke <kenn...@whitecape.org> >>>> >>>> v2 (idr): Don't allow CSEL with a non-float src2. >>>> >>>> v3 (idr): Add CSEL to fs_inst::flags_written. Suggested by Matt. >>> >>> brw_disassemble_inst >>> fs_visitor::dump_instruction >>> vec4_instruction:writes_flag >>> vec4_visitor::dump_instruction >> >> Do we need to update vec4 code? This instruction is BDW+, and we don't >> use the vec4 backend for anything on those platforms... and this >> optimization is FS-only. > > Not strictly necessary, but those conditions are checking the same > thing so I'd keep them in sync.
Ok. How can I test various dump_instruction and brw_disassemble_inst paths? _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
