On 04.01.2018 18:37, Andres Rodriguez wrote:



On 2018-01-04 12:33 PM, Marek Olšák wrote:
Is the renaming necessary? It looks like everything would be fine if
we used the "fence" name for semaphores.


The rename was requested by nha. We could keep going with the fences name. Or we could do the whole rename afterwards. I'm fine with either approach.

Still digging through emails, but Marek pointed this out specifically.

It's been a while, but this may have been a misunderstanding. Perhaps you were referring to my mail to your first series about semaphores ("Add support for GL_EXT_semaphore") in early November. What I meant to request is that we use the same object for both fences and semaphores, and that object would have behavior closer to semaphores (since they're kind of a superset in terms of behavior). I didn't mean to say that they should necessarily be renamed. My apologies for not making that clear.

So I was actually expecting to keep the fence name, there's some benefit to having less churn.

Cheers,
Nicolai



Marek

On Fri, Dec 22, 2017 at 1:41 AM, Andres Rodriguez <andre...@gmail.com> wrote:
Rename fences -> semaphores in preparation for upgrading fence
functionality.

This series renames the following symbols:
   - pipe_fence_handle -> pipe_semaphore_handle
   - fence_server_sync -> semaphore_server_sync
   - create_fence_fd -> create_semaphore_fd
   - fence_reference -> semaphore_reference
   - fence_finish -> semaphore_finish
   - fence_get_fd -> semaphore_get_fd
   - PIPE_FLUSH_FENCE_FD -> PIPE_FLUSH_SEMAPHORE_FD
   - PIPE_CAP_NATIVE_FENCE_FD -> PIPE_CAP_NATIVE_SEMAPHORE_FD


_______________________________________________
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev


--
Lerne, wie die Welt wirklich ist,
Aber vergiss niemals, wie sie sein sollte.
_______________________________________________
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Reply via email to