On Dec 21, 2017, at 6:41 PM, Andres Rodriguez
<[email protected]<mailto:[email protected]>> wrote:
Rename fences -> semaphores in preparation for upgrading fence
functionality.
This series renames the following symbols:
- pipe_fence_handle -> pipe_semaphore_handle
- fence_server_sync -> semaphore_server_sync
- create_fence_fd -> create_semaphore_fd
- fence_reference -> semaphore_reference
- fence_finish -> semaphore_finish
- fence_get_fd -> semaphore_get_fd
- PIPE_FLUSH_FENCE_FD -> PIPE_FLUSH_SEMAPHORE_FD
- PIPE_CAP_NATIVE_FENCE_FD -> PIPE_CAP_NATIVE_SEMAPHORE_FD
This patch does not introduce any functionality changes.
Hi Andres. This rename leaves the drivers in a weird mixed nomenclature between
fence and semaphore. Is there a plan to clean this up?
Example, pulled from lp_screen.c:
* Fence reference counting.
*/
static void
-llvmpipe_fence_reference(struct pipe_screen *screen,
- struct pipe_fence_handle **ptr,
- struct pipe_fence_handle *fence)
+llvmpipe_semaphore_reference(struct pipe_screen *screen,
+ struct pipe_semaphore_handle **ptr,
+ struct pipe_semaphore_handle *fence)
{
struct lp_fence **old = (struct lp_fence **) ptr;
struct lp_fence *f = (struct lp_fence *) fence;
- lp_fence_reference(old, f);
+ lp_semaphore_reference(old, f);
}
We're casting semaphore handles to lp_fence pointers and passing
fences into lp_semaphore_reference. A confusing mix of terminology.
_______________________________________________
mesa-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
