On Sun, Jan 7, 2018 at 9:51 PM, Ilia Mirkin <imir...@alum.mit.edu> wrote: > On Sun, Jan 7, 2018 at 3:42 PM, Karol Herbst <kher...@redhat.com> wrote: >> significant changes to last series: >> * disable support for 64 bit types >> * fix tessellation shader bugs >> * assume vec4 elements for variable index arrays (MemoryOpts workaround) >> >> piglit run -x glx -x egl -x streaming-texture-leak -x max-texture-size >> tests/gpu.py: >> [26010/26010] skip: 10410, pass: 15386, warn: 9, fail: 191, crash: 14 > > Great work! > >> >> remaining issues: >> * transform feedback with geometry shaders > > This could be some very important issue. I'd highly recommend looking > into it in some depth. >
I think in the end it is a gallium issue related to NIR, TF and geometry shaders. most of the transform feedback related tetsts are passing (around 95%), so I really don't worry too much about those. Still want to look at it, but I don't see it as critical right now. >> * indirects in image_load/store >> * interpolateAt > > I'd ignore those. It's unlikely to be anything too structural. > >> * getting 64 bit types to work. This is mainly limited by codegen RA being >> not able to handle those correctly, because from_TGSI just generates merge >> and splits and doesn't hit the faulty paths. > > Just generate the merges and splits like I told you initially. Store > 64-bit vars into a merge of 2 original Value's. > yeah, just need to come up with a nice way of doing that :) > I haven't looked at the patches, but have you fixed up the pipe caps > to disable the various features/etc that you don't implement when > using nir? > > -ilia well I disabled PIPE_CAP_DOUBLES, PIPE_CAP_INT64 and PIPE_CAP_TEXTURE_GATHER_OFFSETS when using NIR. _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
