On Thursday, 2017-11-23 13:32:47 +0000, Emil Velikov wrote: > Hi Eric, > > On 22 November 2017 at 17:59, Eric Engestrom <eric.engest...@imgtec.com> > wrote: > > A recent thread [1] made me check our local specs to see which ones were > > upstream. This series removes the ones that are identical upstream > > (modulo "TBD" extension numbers in some cases). > > > > There are a few more specs left that are upstream, but have typo fixes > > that I'm going to submit to Khronos, and I'll remove the local copies > > once the fixes have been upstreamed: > The idea sounds great, just some minor comments - mostly about > potential deprecation. > > > - EGL_MESA_drm_image > The extension, lacks information about error handling (et al) and is > no longer used. > There is even an extra bitmask in eglmesaext.h that's quite meh thing to do. > Perhaps we should consider officially deprecating it as hinted earlier [1] > > [1] https://lists.freedesktop.org/archives/mesa-dev/2017-June/161575.html
What does "deprecate" mean exactly, in this context? Move to docs/specs/OLD/? Should anything be done in the upstream specs to flag them as deprecated? > > > - GLX_MESA_release_buffers > Extension is implemented only for Xlib based libGL. The DRI codepath > has a TODO for at least 7 years. > Worth checking if anyone uses it and not just deprecate the extension? I don't know much about GLX, so I'll let someone else do this. > > > Eric Engestrom (7): > > docs/specs: remove upstreamed spec EGL_MESA_platform_surfaceless > > docs/specs: remove upstreamed spec MESA_image_dma_buf_export > > docs/specs: remove upstreamed spec MESA_shader_integer_functions > > docs/specs: remove upstreamed spec EXT_shader_integer_mix > > > docs/specs: remove upstreamed spec MESA_agp_offset > > docs/specs: remove upstreamed spec MESA_pixmap_colormap > > docs/specs: remove upstreamed spec MESA_set_3dfx_mode > These three are also Xlib libGL only. Above idea applies. ditto > > > > There are a few references to the spec files in docs/. Can you update those? Good point, I forgot to check. I've amended each commit to update the respective links from docs/extensions.html and docs/xlibdriver.html, and I'll send a v2 later today/tomorrow with all the other duplicate OpenGL specs deleted as well, since Jon has merged the fixes upstream a couple hours ago. (The EGL one needed a fix from me, so it's not merged yet) I have pushed a branch here if anyone wants: https://github.com/1ace/mesa cleanup/remove-upstream-specs > > The series looks OK, yet blessing from veterans is appreciated > Acked-by: Emil Velikov <emil.veli...@collabora.com> Thanks; I took the liberty to apply your ack to the new commits as well. I'll definitely leave this series sitting for a while, I want the "veterans" to see this and ack it first :) > > > Thanks > Emil _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
