On Friday, September 8, 2017 6:33:44 AM PDT Emil Velikov wrote: > Hi Eric, > > On 8 September 2017 at 13:40, Eric Engestrom <eric.engest...@imgtec.com> > wrote: > > Instead of setting based on set/unset, allow users to use boolean values. > > In the docs, use `ALWAYS=true` instead of `ALWAYS=1` as it's clearer IMO. > > > I'm a bit weary about this series. In the past we had cases where > people will set the variable to empty string and/or 0 and expect > things to work. > > IIRC the older Intel QA team was using it, not sure about now. Either > way it's great to confirm with a few people before pushing this.
That team is gone. I like the consistency of using env_var_as_boolean across the codebase - it might break a few things, but I think that's okay. Most people don't use this, and most of those that do use =1. > That aside, env_var_as_boolean() treats 'yes', '1' and 'true' in > identical manner. Perhaps we can state what a "boolean variable" is > and use that reference through the documentation? > > -Emil That seems like a good idea.
signature.asc
Description: This is a digitally signed message part.
_______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
