On 2 August 2017 at 21:24, Adam Jackson <a...@redhat.com> wrote:
> The device extension string is expected to contain the name of the
> extension defining what kind of device it is, so the caller can know
> what kinds of operations it can perform with it. So that string had
> better be non-empty, hence this trivial extension.
>
Is there something that forbids a EGL device to advertise an empty string?
I don't recall such text.

Regardless, I think this (esp. combined with the extension in 3/3) is
a good idea.
One minor suggestion below.

> +Overview
> +
> +    This extension defines a software EGL "device". The device is not backed 
> by
> +    any actual device node and simply renders into client memory.
> +
> +    By defining this as an extension, EGL_EXT_device_enumeration is able to
> +    sanely enumerate a software fallback device.
> +
Drop "fallback"? Despite how crazy it sounds it's not impossible to
have a system with only software device(s).
Hopefully we won't see too many.

Thanks
Emil
_______________________________________________
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Reply via email to