On Fri, 23 Dec 2011 20:57:46 -0800, Kenneth Graunke <kenn...@whitecape.org> 
wrote:
> In this code, 'i' loops over the number of virtual GRFs, while 'j' loops
> over the number of vector components (0 <= j <= 3).
> 
> It can't possibly be correct to see if bit 'i' is set in the destination
> writemask, as it will have values much larger than 3.  Clearly this is
> supposed to be 'j'.
> 
> Found by inspection.

Yeah, making a runtime test for this one would suck.

Reviewed-by: Eric Anholt <e...@anholt.net>

Attachment: pgpDUd5Ti1Lqq.pgp
Description: PGP signature

_______________________________________________
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Reply via email to