On Fri, 2011-12-23 at 20:57 -0800, Kenneth Graunke wrote: > In this code, 'i' loops over the number of virtual GRFs, while 'j' loops > over the number of vector components (0 <= j <= 3). > > It can't possibly be correct to see if bit 'i' is set in the destination > writemask, as it will have values much larger than 3. Clearly this is > supposed to be 'j'. > > Found by inspection. > > Cc: Eric Anholt <e...@anholt.net> > Cc: Matt Turner <matts...@gmail.com> > Cc: Christopher James Halse Rogers <chalserog...@gmail.com> > Signed-off-by: Kenneth Graunke <kenn...@whitecape.org> > --- > .../drivers/dri/i965/brw_vec4_copy_propagation.cpp | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > Matt and Christopher, > > Could you test Counter Strike and Civ V with this patch series? > I think it should solve your regressions with the new VS backend.
Works a treat. For the series: Tested-by: Christopher James Halse Rogers <christopher.halse.rog...@canonical.com>
signature.asc
Description: This is a digitally signed message part
_______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
