I dropped a minor suggestion in patch 7 (feel free to ignore) and a style issue in patch 8, otherwise:
Patches 1-8 are: Reviewed-by: Iago Toral Quiroga <ito...@igalia.com> On Tue, 2017-06-13 at 11:41 -0700, Nanley Chery wrote: > This series implements refactors and behavioral changes to make the > follow-on series which implements layout-based CCS resolves a lot > clearer. > > Cc: Jason Ekstrand <ja...@jlekstrand.net> > > Nanley Chery (13): > intel/blorp: Assert on subresource in surface_info_init > intel/blorp: Assert on gen7 fast-cleared subresource > intel/isl: Limit CCS to one subresource on gen7 > intel/isl: Only create a CCS buffer if the image supports rendering > anv: Add and use color auxiliary buffer helpers > anv/cmd_buffer: Adjust layout transition aspect checking > anv/blorp: Remove 3D subresource transition workaround > anv: Adjust params of color buffer transitioning functions > anv/cmd_buffer: Adjust the image view reloc function > blorp/clear: Add a binding-table-based CCS resolve function > anv/blorp: Add a surface-state-based CCS resolve function > anv/blorp: Provide surface states for CCS resolves > anv/gpu_memcpy: Rename the gpu_memcpy function > > src/intel/blorp/blorp.c | 4 ++ > src/intel/blorp/blorp.h | 11 ++++ > src/intel/blorp/blorp_clear.c | 66 ++++++++++++++++++------ > src/intel/isl/isl.c | 11 ++-- > src/intel/vulkan/anv_blorp.c | 103 +++++++++++++++++++++++-- > ------------ > src/intel/vulkan/anv_genX.h | 8 +-- > src/intel/vulkan/anv_private.h | 49 +++++++++++++++++- > src/intel/vulkan/genX_cmd_buffer.c | 94 +++++++++++++++++++------ > -------- > src/intel/vulkan/genX_gpu_memcpy.c | 8 +-- > 9 files changed, 248 insertions(+), 106 deletions(-) > _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
