On 12/06/17 06:32 PM, Gert Wollny wrote: > Am Montag, den 12.06.2017, 15:44 +0900 schrieb Michel Dänzer: >> On 10/06/17 08:15 AM, Gert Wollny wrote: >>> >>> Piglit shows 7 fixes and 6 regressions compared to git 8fac894f, >>> but they don't >>> seem to be related to shaders. >> >> Which tests regressed (maybe you can put up a piglit HTML summary >> somewhere generated from a run with and without your patches)? Do >> they consistently pass without your patches and fail with them? > > > I had to redo the results, because I realized that I had compared the > system mesa version (with EGL support) versus the test version (without > EGL support). > > Now both tested versions were configure with the same options and I run > both versions two times. The result diff of the quick test are: > > piglit summary console -d results/o1 results/o2 results/n1 results/n2 > > glx/glx-multithread-texture: pass pass fail fail
Might want to make sure this isn't a regression caused by your patches, but FWIW this test seems to fail for me with radeonsi with "random" values. > glx/glx_arb_sync_control/timing -fullscreen -divisor 1: pass fail pass > fail > glx/glx_arb_sync_control/timing -fullscreen -divisor 2: pass fail fail > warn > glx/glx_arb_sync_control/timing -fullscreen -msc-delta 1: fail fail > warn fail > glx/glx_arb_sync_control/timing -fullscreen -msc-delta 2: fail fail > fail pass > glx/glx_arb_sync_control/timing -msc-delta 2: warn fail pass fail > glx/glx_arb_sync_control/timing -waitformsc -msc-delta 2: fail pass > pass fail You can ignore these, their results are somewhat random. The piglit patches below help a little, but the results are still not 100% reliable when piglit runs multiple tests concurrently. https://patchwork.freedesktop.org/patch/150486/ https://patchwork.freedesktop.org/patch/150484/ https://patchwork.freedesktop.org/patch/150485/ In summary, it looks like your patches don't cause any piglit regressions. -- Earthling Michel Dänzer | http://www.amd.com Libre software enthusiast | Mesa and X developer _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
