On Monday, 2017-06-05 00:03:59 +0100, Emil Velikov wrote: > As described inline - follow what's written in the manual and what works > for all platforms that Mesa supports. > > We want to untangle things leaving only -pthread, yet that has a > potential of causing regressions. Thus we'll do it as a follow-up patch. > > As a nice side-effect this resolves issues, where the system lacks > libpthread.so, yet the linker does not warn about it and we and up with > unresolved symbols. > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=101071 > Cc: mesa-sta...@lists.freedesktop.org > Signed-off-by: Emil Velikov <emil.veli...@collabora.com>
Series is: Reviewed-by: Eric Engestrom <eric.engest...@imgtec.com> I think you should push 1+3+4, 2 can wait for the various confirmations you requested. > --- > configure.ac | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/configure.ac b/configure.ac > index 5caf316089a..1c15eb482f9 100644 > --- a/configure.ac > +++ b/configure.ac > @@ -837,6 +837,11 @@ dnl is not valid for that platform. > if test "x$android" = xno; then > test -z "$PTHREAD_LIBS" && PTHREAD_LIBS="-lpthread" > fi > +dnl According to the manual when using pthreads, one should add -pthread to > +dnl both compile and link-time arguments. > +dnl In practise that should be sufficient for all platforms, since any > +dnl platforms build with GCC and Clang support the flag. > +PTHREAD_LIBS="$PTHREAD_LIBS -pthread" > > dnl pthread-stubs is mandatory on BSD platforms, due to the nature of the > dnl project. Even then there's a notable issue as described in the project > README > -- > 2.13.0 > _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
