On Wed, 14 Dec 2011 15:11:53 -0800, Kenneth Graunke <kenn...@whitecape.org>
wrote:
> On 12/13/2011 01:19 PM, Eric Anholt wrote:
> > On Thu, 8 Dec 2011 17:08:04 -0800, Kenneth Graunke <kenn...@whitecape.org>
> > wrote:
> >> Signed-off-by: Kenneth Graunke <kenn...@whitecape.org>
> >> + if (one_mask) {
> >> + swizzled_result.writemask = one_mask;
> >> + emit(MOV(swizzled_result, src_reg(1.0f)));
> >> + }
> >> }
> >
> > I think this would be wrong for SWIZZLE_ONE of integer textures.
>
> My tests indicate that it works. swizzled_result gets the appropriate
> register type, so this ends up being something like:
>
> mov(8) m4<1>.ywUD 1F { align16 WE_normal 1Q };
>
> and the MOV instruction does the float->int conversion for us.
>
> Is that okay? If not, what would you prefer?Oh, you're right. I was not thinking correctly.
pgpwzhr2ElOtj.pgp
Description: PGP signature
_______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
