On Wednesday, May 24, 2017 1:04:56 PM PDT Matt Turner wrote: > --- > src/mesa/drivers/dri/i965/intel_pixel_read.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/src/mesa/drivers/dri/i965/intel_pixel_read.c > b/src/mesa/drivers/dri/i965/intel_pixel_read.c > index eb3f66f..5085683 100644 > --- a/src/mesa/drivers/dri/i965/intel_pixel_read.c > +++ b/src/mesa/drivers/dri/i965/intel_pixel_read.c > @@ -91,8 +91,7 @@ intel_readpixels_tiled_memcpy(struct gl_context * ctx, > * a 2D BGRA, RGBA, L8 or A8 texture. It could be generalized to support > * more types. > */ > - if (!brw->has_llc || > - !(type == GL_UNSIGNED_BYTE || type == GL_UNSIGNED_INT_8_8_8_8_REV) || > + if (!(type == GL_UNSIGNED_BYTE || type == GL_UNSIGNED_INT_8_8_8_8_REV) || > pixels == NULL || > _mesa_is_bufferobj(pack->BufferObj) || > pack->Alignment > 4 || >
Patches 14-15 are: Reviewed-by: Kenneth Graunke <kenn...@whitecape.org> I think these are fine because MAP_READ | MAP_RAW should cause us to use CPU maps, so LLC/non-LLC shouldn't matter. I forget what Chrome workload benefited hugely from this path on LLC, but it might be nice to quote some numbers.
signature.asc
Description: This is a digitally signed message part.
_______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
