On 9 March 2017 at 16:00, Emil Velikov <emil.l.veli...@gmail.com> wrote:
> Hi Elie,
>
> On 9 March 2017 at 15:16, Elie Tournier <tournier.e...@gmail.com> wrote:
>> udivmod64 appears in src/compiler/glsl/builtin_int64.h and
>> src/compiler/glsl/udivmod.h
>> The second file seems unused.
>> Fix commit 6b03b345eb64e15e577bc8b2cf04b314a4c70537
>>
>> This change doesn't affect shader-db.
>>
> Thanks for double-checking.
>
> Just a couple of nitpicks:
> s/remove unused file/remove unused file udivmod64.h/
> s/udivmod.h/udivmod64.h/
>
> Please use the canonical:
> Fixes: 6b03b345eb6 ("glsl: Add "built-in" function for 64-bit integer sign()")
>
> With the above:
> Suggested-by: Emil Velikov <emil.veli...@collabora.com>
> Reviewed-by: Emil Velikov <emil.veli...@collabora.com>
>
I realise that Ian is away, but if anyone else can confirm that we're
not loosing the plot that will be appreciated :-)
Otherwise I'll be pushing this in a couple of days.
-Emil
_______________________________________________
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
