On 11/18/2011 05:55 PM, Eric Anholt wrote: > On Thu, 17 Nov 2011 19:59:08 -0800, Chad Versace > <chad.vers...@linux.intel.com> wrote: >> I found the line of code that breaks the test, but don't know how to >> easily fix it. >> >> Signed-off-by: Chad Versace <chad.vers...@linux.intel.com> >> --- >> src/mesa/drivers/dri/i965/brw_context.c | 3 +++ >> 1 files changed, 3 insertions(+), 0 deletions(-) >> >> diff --git a/src/mesa/drivers/dri/i965/brw_context.c >> b/src/mesa/drivers/dri/i965/brw_context.c >> index 4d51e62..0021eb5 100644 >> --- a/src/mesa/drivers/dri/i965/brw_context.c >> +++ b/src/mesa/drivers/dri/i965/brw_context.c >> @@ -97,6 +97,9 @@ static void brwPrepareExecBegin(struct gl_context *ctx) >> tex_obj = intel_texture_object(ctx->Texture.Unit[i]._Current); >> if (!tex_obj || !tex_obj->mt) >> continue; >> + /* FIXME: The hiz resolve here (not the depth resolve) breaks Piglit >> + * FIXME: test glean/fbo on gen6. >> + */ >> intel_miptree_all_slices_resolve_hiz(intel, tex_obj->mt); >> intel_miptree_all_slices_resolve_depth(intel, tex_obj->mt); >> } >> -- >> 1.7.7.1 > > I've made it to the end! At this point, I'm up for a known regression > to get this giant series landed. Everything without specific comments > is now: > > Reviewed-by: Eric Anholt <e...@anholt.net>
Thank you thank you for painstakingly reviewing this. You've caught many refcount leaks and potential bugs. ---- Chad Versace chad.vers...@linux.intel.com _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
