On 11/04/2016 05:37 PM, Rob Clark wrote:
On Fri, Nov 4, 2016 at 11:31 AM, Emil Velikov <emil.l.veli...@gmail.com> wrote:
On 1 November 2016 at 22:05, Rob Clark <robdcl...@gmail.com> wrote:
On Tue, Nov 1, 2016 at 5:42 PM, Mauro Rossi <issor.or...@gmail.com> wrote:
Mauro or Chih-Wei should be able to answer this (being do static
wallpapers work in i965?).

Rob

Hi, I've perfomed tests with mesa
https://github.com/maurossi/mesa/commits/13.0.0_nougat-x86
and the deafult pink wallpaper of nougat-x86 is working on i965

NOTE: I have cherry-picked android-ia "Add the RGBA8888 and RGBX8888
back to Intel screen config",
which solved some black rendering issue in Basemark ES2 Taiji 3d
render and in OpenGL ES Examples (last two demos)
but Android wallpaper was working also without it.

fwiw, we have that patch as well..  the issue is not an egl/gl error,
but it happens by chance.  Ie. it requires the egl surface to be
destroyed, and then re-allocated as a different type (such as from
pbuffer to window), and get the idential pointer address as the
previous surface.

In other words, I think the cases where it is working is only by luck.

Can you flesh out the patch in a branch for Mark Janes to run through the CI ?
If it doesn't cause issues on their end it's worth merging it, even if
i965 is fortunate to work without it. Worth adding an inline comment
about the latter ?

For a test run, I guess applying the RFC as-is should be sufficient?
I was planning on sending a non-RFC version of this but haven't had
time/setup to do a piglit run on my end.

I *think* it should be a pretty safe change, but a CI run would be
much appreciated.


I applied this patch on top of cc49505 and did CI run, no regressions.

Acked-by: Tapani Pälli <tapani.pa...@intel.com>

// Tapani
_______________________________________________
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Reply via email to