On 16/09/16 05:15 PM, Michel Dänzer wrote: > On 14/09/16 02:34 PM, Nayan Deshmukh wrote: >> so that the texture is rendered to back buffer before calling >> flush_frontbuffer and can be copied to a different buffer in >> the function >> >> Signed-off-by: Nayan Deshmukh <nayan26deshm...@gmail.com> >> --- >> src/gallium/state_trackers/vdpau/presentation.c | 7 +++++-- >> 1 file changed, 5 insertions(+), 2 deletions(-) >> >> diff --git a/src/gallium/state_trackers/vdpau/presentation.c >> b/src/gallium/state_trackers/vdpau/presentation.c >> index 2862eaf..f35d73a 100644 >> --- a/src/gallium/state_trackers/vdpau/presentation.c >> +++ b/src/gallium/state_trackers/vdpau/presentation.c >> @@ -271,11 +271,14 @@ vlVdpPresentationQueueDisplay(VdpPresentationQueue >> presentation_queue, >> } >> >> vscreen->set_next_timestamp(vscreen, earliest_presentation_time); >> - pipe->screen->flush_frontbuffer(pipe->screen, tex, 0, 0, >> - vscreen->get_private(vscreen), NULL); >> >> + // flush before calling flush_frontbuffer so that rendering is flushed >> + // to back buffer so the texture can be copied in flush_frontbuffer > > Please use C-style /* ... */ comments in C code.
Hmm, actually all comments in this file seem to be C++-style, so I guess it's fine either way. > Same for patch 3. That file only has C-style comments though. BTW, multi-line C-style comments should be formatted like this: /* First line * [more lines] */ -- Earthling Michel Dänzer | http://www.amd.com Libre software enthusiast | Mesa and X developer _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
