On Fri, 2016-07-29 at 12:59 -0700, Francisco Jerez wrote: > | for (unsigned i = 0; i < 2 * inst->regs_written; i++) > { > | for (int c = 0; c < 4; c++) > | result_live[c] |= BITSET_TEST( > | live, var_from_reg(alloc, inst->dst, c, i)); > | } > > Note that the offset call goes away. The factor of two makes sense > because you need to check 4 * 2 * regs_written bits in total, since > you're keeping track of 8 bits per GRF. It would likely make sense > to
Hmm... what about the case of exec_size == 4 and writing just a float? I understand in this case we only should mark one word, so the loop should not be 2*inst->regs_written. Note that in the original patch that was the case for using offs == 0. So I guess we should compute if we should use 1 or 2 times regs_written. J.A.
signature.asc
Description: This is a digitally signed message part
_______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev