On Mon, Jun 27, 2016 at 6:30 PM, Gurchetan Singh
<gurchetansi...@chromium.org> wrote:
> Hi Ilia,
>
> The changes for get.c where prompted by the es3fIntegerStateQueryTests (see
> modules/gles3/functional/es3fIntegerStateQueryTests.cpp in the dEQP tree).
> Specifically, these few lines:
>
>>> const GLint validInitialValues[] = {GL_BACK, GL_NONE};
>>> m_verifier->verifyIntegerAnyOf(m_testCtx, GL_READ_BUFFER,
>>> validInitialValues, DE_LENGTH_OF_ARRAY(validInitialValues));
>>> expectError(GL_NO_ERROR);
>
> We initially set ColorReadBuffer to GL_FRONT in
> _mesa_initialize_window_framebuffer for single-buffered configs.So ... could we initialize it to GL_BACK for GLES and avoid this pain? Unfortunately I have no idea what the implications of that would be. > > We could also make sure the context is single-buffered in get.c to further > avoid bugs. Let me know if that works for you and I'll send a modified > patch. > > I do agree it is a bit hacky ... I'd definitely be interested in alternative > solutions. If you're flipping the value in the getter, you might as well set that to be the value from the very beginning. However I don't know what the effects of that are. -ilia _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
