On Wed, Jun 15, 2016 at 08:51:14PM +0530, Nayan Deshmukh wrote: > Hi Eric, > > Sorry for the typo in commit message. > > I made two separate patches as one was for mesa and other for gallium it
Indeed, I completely missed that and you're right for doing it :) Sent my r-b on the v2. > has nothing to do with the use of "f" and "F". Regarding replacing the "F" > with "f", maybe someone can shed some light as to why "F" was used > specifically. > > Regards, > Nayan. > > On Wed, Jun 15, 2016 at 6:32 PM, Eric Engestrom <eric.engest...@imgtec.com> > wrote: > > > On Wed, Jun 15, 2016 at 03:38:05PM +0530, Nayan Deshmukh wrote: > > > Signed-off-by: Nayan Deshmukh <nayan26deshm...@gmail.com> > > > --- > > > src/mesa/drivers/dri/r200/r200_swtcl.c | 6 +++--- > > > 1 file changed, 3 insertions(+), 3 deletions(-) > > > > > > diff --git a/src/mesa/drivers/dri/r200/r200_swtcl.c > > b/src/mesa/drivers/dri/r200/r200_swtcl.c > > > index 72f09ae..d3fb37f 100644 > > > --- a/src/mesa/drivers/dri/r200/r200_swtcl.c > > > +++ b/src/mesa/drivers/dri/r200/r200_swtcl.c > > > @@ -835,9 +835,9 @@ r200PointsBitmap( struct gl_context *ctx, GLint px, > > GLint py, > > > else > > > f = _swrast_z_to_fogfactor(ctx, ctx->Current.RasterDistance); > > > > > > - color[0] = f * rc[0] + (1.F - f) * fc[0]; > > > - color[1] = f * rc[1] + (1.F - f) * fc[1]; > > > - color[2] = f * rc[2] + (1.F - f) * fc[2]; > > > + color[0] = f * rc[0] + (1.0F - f) * fc[0]; > > > + color[1] = f * rc[1] + (1.0F - f) * fc[1]; > > > + color[2] = f * rc[2] + (1.0F - f) * fc[2]; > > > color[3] = rc[3]; > > > > > > UNCLAMPED_FLOAT_TO_CHAN(vert.tv.color.red, color[0]); > > > -- > > > 2.5.5 > > > > Commit title has a typo: s/0.F/1.0F/ > > > > And the only difference between the commits is the case of the "f", > > not sure it warrants being its own commit for that. > > IMHO you could even replace those `1.0F` with `1.0f`, unless this was > > done as some attempt to distinguish from `f`, in which case it would > > probably be better to just rename `f` to `factor` instead. > > But that's a different topic. > > > _______________________________________________ > mesa-dev mailing list > mesa-dev@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/mesa-dev _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
