Alejandro Piñeiro <apinhe...@igalia.com> writes: > If the src is invalid, so src size is zero, the src_sz passed to emit > send should be zero too, instead of a default 1 if we are in a simd4x2 > case. This can happens if using emit_untyped_atomic for an atomic > dec/inc. > > v2: use the proper src_sz when calling emit_send, instead of just > avoid loading src at emit_send if BAD_FILE (Francisco Jerez)
Thanks!
Reviewed-by: Francisco Jerez <curroje...@riseup.net>
> ---
> src/mesa/drivers/dri/i965/brw_vec4_surface_builder.cpp | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/mesa/drivers/dri/i965/brw_vec4_surface_builder.cpp
> b/src/mesa/drivers/dri/i965/brw_vec4_surface_builder.cpp
> index 28002c5..1db349a 100644
> --- a/src/mesa/drivers/dri/i965/brw_vec4_surface_builder.cpp
> +++ b/src/mesa/drivers/dri/i965/brw_vec4_surface_builder.cpp
> @@ -221,7 +221,7 @@ namespace brw {
> emit_insert(bld, addr, dims, has_simd4x2),
> has_simd4x2 ? 1 : dims,
> emit_insert(bld, src_reg(srcs), size, has_simd4x2),
> - has_simd4x2 ? 1 : size,
> + has_simd4x2 && size ? 1 : size,
> surface, op, rsize, pred);
> }
>
> --
> 2.5.0
signature.asc
Description: PGP signature
_______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
