The same functionality is provided by emit_untyped_atomic and emit_untyped_read at surface_access. Having two implementations of the same is among other things confusing (I initially spent some time checking if there was any practical reason to have both).
The real removal is done on the second patch. I also fixed the indentation of that part. The first patch fixes a small problem on surface_access::emit_send, as it didn't take into account that the src could be a bad_file. This can happens on inc/dec atomic counters. The last patch is just some minor cleaning. Alejandro Piñeiro (3): i965/vec4: don't load src on emit_send if it is BAD_FILE i965/vec4/nir: remove emit_untyped_surface_read and emit_untyped_atomic at brw_vec4_visitor i965/vec4/nir: no need to use surface_access:: to call emit_untyped_atomic src/mesa/drivers/dri/i965/brw_vec4.h | 7 --- src/mesa/drivers/dri/i965/brw_vec4_nir.cpp | 50 ++++++++++++-------- .../drivers/dri/i965/brw_vec4_surface_builder.cpp | 7 +-- src/mesa/drivers/dri/i965/brw_vec4_visitor.cpp | 55 ---------------------- 4 files changed, 35 insertions(+), 84 deletions(-) -- 2.5.0 _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev