On Sun, Jan 31, 2016 at 2:37 AM, Dave Airlie <airl...@gmail.com> wrote: >> + for (i = 0; i < program->shader->NumImages; i++) { >> + if (program->images_used & (1 << i)) { >> + t->images[i] = ureg_DECL_image(ureg, i, >> + program->image_targets[i], >> + program->image_formats[i], >> + true, false); > > Can we not know if the image is writable from the GL level?
Yes, we can. But do we care? It was there already so I kept the flag, but I'd be fully in favor of removing it... layout(writeonly) in GLSL lets you not specify a format, which would come through as PIPE_FORMAT_NONE in here. But beyond validation, I don't see what the use is. Something like layout(readonly) just causes imageStore() to error out... Cheers, -ilia _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev