Hi Marek, On 22 January 2016 at 12:24, Marek Olšák <mar...@gmail.com> wrote: > Hi Emil, > > Do you have any comment on this series? > I was secretly hoping that you'll forget about this patch because...
> Marek > > On Tue, Jan 12, 2016 at 8:46 PM, Marek Olšák <mar...@gmail.com> wrote: >> From: Marek Olšák <marek.ol...@amd.com> >> >> This allows building VDPAU/OMX/VA drivers without OpenGL and its >> dependencies. >> --- >> configure.ac | 5 +++++ >> 1 file changed, 5 insertions(+) >> >> diff --git a/configure.ac b/configure.ac >> index 8d19dab..04b5fd8 100644 >> --- a/configure.ac >> +++ b/configure.ac >> @@ -2159,7 +2159,12 @@ gallium_require_drm_loader() { >> fi >> } >> >> +dnl This is for Glamor. Skip this if OpenGL is disabled. >> require_egl_drm() { >> + if test "x$enable_opengl" = xno; then >> + return 0 >> + fi >> + >> case "$with_egl_platforms" in >> *drm*) >> ;; ... the hole idea of having this error out is a gross workaround imho. While I could not find anything concrete to point out initially seems like you have found it. And now we add a workaround on top of the workaround :-\ Yes it is (very) unlikely that radeonsi GPUs will have 2d accel without glamor and yes it is required in those cases. But that does not mean that we must mandate egl+drm but recommend it ? After all one can have egl+wayland+radeonsi mesa (without egl+drm) on a xserver-less setup, can't they ? So what I'm proposing here is that we change the AC_MSG_ERROR to AC_MSG_WARN and drop this patch. -Emil P.S. Pardon for the wall of text. _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev