On 11/29/2015 07:21 AM, Emil Velikov wrote: > Hi Giuseppe, > > On 28 November 2015 at 15:43, Giuseppe Bilotta > <giuseppe.bilo...@gmail.com> wrote: >> The second and third patches are mostly aimed at removing non-spurious >> compiler warnings. The first one is just minor whitespace cleanup in the >> general area of code touched by the second patch. >> >> Giuseppe Bilotta (3): >> radeon: whitespace cleanup >> radeon: const correctness >> xvmc: force assertion in XvMC tests >> > With the small comment in patch 3 addressed the series is > Reviewed-by: Emil Velikov <emil.l.veli...@gmail.com> > > If you're looking for an easy task - there is one in radeon/r200. > Currently we have a lot of nasty in-tree symlinks, symbol duplication > and hacks to get around it. Let me know if you'd like more info/tips > on how to tackle it.
This is something that has been annoying me a bit lately. What do you think the right solution is? The Intel driver used to have a common src/mesa/drivers/dri/intel directory that was compiled once and shared by i915 and i965. The code paths started to diverge quite a lot, so we copied the shared files into each directory... and became non-shared. Note that we didn't rename any of the function names, so we still have the ugly hacks to get around the symbol duplication. > Thanks > Emil > _______________________________________________ > mesa-dev mailing list > mesa-dev@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/mesa-dev _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
