On Monday, November 30, 2015 07:55:02 PM Ilia Mirkin wrote: > How sure are you about this? This would make it very annoying to > implement on recent (kepler+) nvidia hardware... there are 16 constbuf > positions total, of which one has to contain texture descriptor data > (mandated by the hw), and it's common to have at least one > driver-internal one. If you're careful it could be shared with the > texture one, but iirc nvidia isn't too careful about it. FWIW nouveau > currently exposes 13, while nvidia apparently does 14.
Without this patch, the game gives me: Mesa: User error: GL_INVALID_VALUE in glBindBufferBase(index=68) Mesa: User error: GL_INVALID_VALUE in glUniformBlockBinding(block binding 68 >= 60) and Talion's body doesn't render at the in-game menu - totally missing. So, something is clearly needed. However, 14 * 5 (VS,TCS,TES,GS,FS) = 70, so exposing a maximum of 14 should work fine. AMD seems to expose more, but Intel/Windows and NVidia do expose 14: http://delphigl.de/glcapsviewer/gl_stats_caps_single.php?listreportsbycap=GL_MAX_UNIFORM_BUFFER_BINDINGS I think I'll change the patch to expose 14 instead. --Ken
signature.asc
Description: This is a digitally signed message part.
_______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev