On Wed, 27 Jul 2011 16:58:41 -0700, Kenneth Graunke <kenn...@whitecape.org> wrote: > The purpose of the (irb->draw_offset & 4095) != 0 check was to ensure > that we don't have XYy offsets into a tile, since Gen4 hardware doesn't > support that. However, it's insufficient: there are cases where > draw_offset & 4095 is 0 but we still have a Y-offset. This leads to an > assertion failure in brw_update_renderbuffer_surface with tile_y != 0. > > Instead, simply call intel_renderbuffer_tile_offsets to compute the > actual X/Y offsets and check if either are non-zero. This makes both > the workaround and the assertion check the same things. > > Fixes piglit test fbo-generatemipmap-formats, and should also fix > bugs #34009 and #39487.
Looks good to me.
pgp2wlDS1zXNQ.pgp
Description: PGP signature
_______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
