On Tue, Jun 15, 2010 at 4:26 PM, Dan Nicholson <dbn.li...@gmail.com> wrote: > On Tue, Jun 15, 2010 at 3:32 PM, tom fogal <tfo...@alumni.unh.edu> wrote: >> Dan Nicholson <dbn.li...@gmail.com> writes: >>> On Tue, Jun 15, 2010 at 12:55 PM, tom fogal <tfo...@alumni.unh.edu> wrote: >>> > Ian Romanick <i...@freedesktop.org> writes: >>> >> > If there are no objections, I will clean up the release notes and >>> >> > make the release tomorrow (Wednesday) morning. =C2=A0It looks like a >>> >> > few things got cherry-picked in the last week, so I'm assuming >>> >> > everything is in that people care about. >>> > >>> > OSMesa, which appears to get built by default --with-driver=3Dxlib, is >>> > broken on darwin w/ current 7.8 HEAD [1]: >> [snip -- undefined refs] >>> > Though I'm guessing this came from the symbol visibility changes >>> > (addition of -fvisibility=hidden), I don't have the time before >>> > tomorrow (or even this week :\) to take a real look. >>> >>> This is also the case on linux. >>> >>> https://bugs.freedesktop.org/show_bug.cgi?id=3D28305 >> >> Ahh, yeah, I guessed as much -- errors linking shlibs on OS X usually >> manifest as errors linking apps on Linux -- but I hadn't tested as >> much. >> >>> I think the "solution" here is to stop linking OSMesa against GL and >>> instead just pull in libmesa and friends all the time. In addition >>> to avoiding the symbol visibility issues, it makes OSMesa more >>> standalone, which is what people want anyway. >> >> Well, personally, I'd rather get glX* + OSMesa* + `normal' gl fqns in >> one lib, but I admit I'm probably the only one... > > I think it should be the same. The only difference is that you don't > get file size savings because you have libmesa and friends built into > both libGL and libOSMesa. But I've never really used OSMesa, so I > could be dead wrong. > >>> I have a patch I was working on but haven't tested. I'll try to wrap >>> it up tonight and shoot it over to you for a test. I'm attaching what >>> I have right now if you want to play around with it. >> >> Thanks. The osmesa/Makefile changes didn't apply, so I did them >> manually.. which was very odd, because I don't see how the patch is >> different from what you sent. Anyway, the attached patch fixes the >> problem; I can build both xlib and standalone OSMesa on 10.5 w/ it. > > Cool. That diff was against master from like two months ago. I think > that's all that's needed, but let me see if there's any other clean up > that can be added.
OK, I pushed the commit to master and 7.8 and added your Tested-by (I hope you don't mind). I think there's some definite build improvements with how osmesa is handled, but that's another story. This should be good for 7.8.2. -- Dan _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
