On Mon, Nov 14, 2016 at 10:51 AM, Eric A. Borisch <ebori...@macports.org> wrote:
> If I see something like this -- https://github.com/ > macports/macports-ports/pull/37 -- come through, and it LGTM, do I just > push the big 'Rebase and merge' button on the GitHub GUI? (This particular > one is an update to a nomaintainer port (fish) to the latest upstream > version, removes no-longer-needed patches, and removes the $Id$ line). > > Let's assume I've tested the changes locally already, and think it is good > to go for the sake of limiting this discussion. > > Thanks, > - Eric > Additionally, this PR also has changes requested by another committer, and acted upon (source of the second commit) by the requestor in the pull request. If I were to push the "Rebase and merge", should I first "Dismiss review" with "Requested changes made" as the reason? - Eric
