On Tue, May 16, 2006 at 03:55:58PM +0200, Per Olofsson wrote: > Sven Hoexter:
Hi all, sorry for the delay but I had to attend a wedding party and a two birthday partys during the last days. Ok let's go for the second round. The package is again on: http://sven.stormbind.net/debian/dvipost/ > > So if you've some spare time please give it a try and if you're > > familiar with Debian packages please look over the source package > > aswell. > > Good work! > > Some suggestions: > > * It should be possible to have TeXlive installed instead of teTex. It > should probably depend on tetex-bin | texlive-base-bin or something. Is this texlive stuff actually packaged within Debian? I cannot find a package with tex and live in the name. The only reference I can find is in the description of the tex-common package. > * There are missing ending newlines in postinst and postrm. done. > * Do you really need to create those directories listed in > debian/dirs? usr/sbin was useless so I removed it. > * The configure script checks things by running kpsewhich and > tex. These are not listed in the Build-Depends. You should probably > try to hardwire these values, or, if you must, build-depend on TeX. Commented that stuff out - patches/ file 03 and 04. > * There are lintian errors. Please fix them. Those should be fixed now. I thought that running lintion on the .dsc file would check the source and the binary package. > * The package is configured two times when using debuild (which uses > dpkg-buildpackage). The problem seems to be the patch target > dependency. You should probably move the dependency from the > config.status target to the build target (before build-stamp). done. Cheers, Sven -- If you won't forgive me the rest of my life Let me apologize while I'm still alive I know it's time to face all of my past mistakes [Less than Jake - Rest Of My Life]
signature.asc
Description: Digital signature
