On Tue, May 16, 2006 at 03:55:58PM +0200, Per Olofsson wrote: > Sven Hoexter: > > Hi all, > > yesterday I've been working on Matej Cepl's dvipost package > > so that it can stand the Debian QA and move into the main > > archive. > > > > So if you've some spare time please give it a try and if you're > > familiar with Debian packages please look over the source package > > aswell. > > Good work! *sigh* and still so many glitches left to workaround ... > Some suggestions: > > * It should be possible to have TeXlive installed instead of teTex. It > should probably depend on tetex-bin | texlive-base-bin or something. Oh I remember I've read something about TeXlive somewhere somewho. I definetly need to dig deeper here. Good point.
> BTW, is it really necessary to depend on TeX at all? Can't this > package be used without TeX, if you have a DVI file? Maybe you > should just recommend TeX instead? Well my Tex knowledge is very low (that's why I like to put Lyx between me and latex) but I think it's needed to register the style file dvipost.sty. So with my current knowledge I think Tex is required. > * There are missing ending newlines in postinst and postrm. Hmpf fixed that in control, donno why I missed those two. Fixed now. > * You should use dh_installtex instead of running texhash manually (I > think). Have you read the TeX policy in the tex-common package? Also > see the dh_installtex(1) manpage. I had to ask on the mentors mailinglist and Frank did not recommend dh_installtex. (hm I would like to copy and paste the link but somehow I'm unable to copy and paste from from elinks with gpm *grummel*) Reading the manpage it's talking about mapfiles and language files and the examples have nothing with .sty. As said above I've no clue about the inner workings of latex. > * Do you really need to create those directories listed in > debian/dirs? Hm not all of them. > * The configure script checks things by running kpsewhich and > tex. These are not listed in the Build-Depends. You should probably > try to hardwire these values, or, if you must, build-depend on TeX. Sure, need to patch that out. Frank told me that those workarounds used in the configure script are ugly and wrong. > * There are lintian errors. Please fix them. Hm with which options did you run lintian? > * The package is configured two times when using debuild (which uses > dpkg-buildpackage). The problem seems to be the patch target > dependency. You should probably move the dependency from the > config.status target to the build target (before build-stamp). Ah that's a little bit odd. We need to patch some things in configure and makefile.in so the patches have to be applied bevore the first configure run. Guess I've to re-read some things about dpatch. Thanks for your detailed feedback. Sv*back-to-work*en -- If you won't forgive me the rest of my life Let me apologize while I'm still alive I know it's time to face all of my past mistakes [Less than Jake - Rest Of My Life]
