Abdelrazak Younes wrote:
Georg Baum wrote:
Am Sonntag, 3. September 2006 12:11 schrieb Abdelrazak Younes:
This patch fixes the isDigit() MSVC warning in ControlSpellchecker.C.
If that is really the correct isDigit() check for unciode
My understanding is that ascii is a subset of ucs4 so it must work as is.
then you simply could have changed the argument type of the existing
function.
I did not touch this on purpose because of the FIXME comment...
So why not changing all the methods in textutils.h instead? Most of our
use are unicode anyway.
This patch doest just that... OK?
Abdel.
Index: textutils.h
===================================================================
--- textutils.h (revision 14870)
+++ textutils.h (working copy)
@@ -15,10 +15,11 @@
#ifndef TEXTUTILS_H
#define TEXTUTILS_H
+#include "support/types.h"
/// return true if the char is a line separator
inline
-bool isLineSeparatorChar(char c)
+bool isLineSeparatorChar(lyx::char_type c)
{
return c == ' ';
}
@@ -26,7 +27,7 @@
/// return true if a char is alphabetical (including accented chars)
inline
-bool isLetterChar(unsigned char c)
+bool isLetterChar(lyx::char_type c)
{
return (c >= 'A' && c <= 'Z')
|| (c >= 'a' && c <= 'z')
@@ -36,7 +37,7 @@
/// return true if the char is printable (masked to 7-bit ASCII)
inline
-bool isPrintable(unsigned char c)
+bool isPrintable(lyx::char_type c)
{
return (c & 127) >= ' ';
}
@@ -44,15 +45,14 @@
/// return true if the char is printable and not a space (masked to 7-bit
ASCII)
inline
-bool isPrintableNonspace(unsigned char c)
+bool isPrintableNonspace(lyx::char_type c)
{
return isPrintable(c) && c != ' ';
}
-
-/// completely pointless FIXME
+/// return truetest if a unicode char is a digit.
inline
-bool isDigit(unsigned char ch)
+bool isDigit(lyx::char_type ch)
{
return ch >= '0' && ch <= '9';
}
