Am Sonntag, 3. September 2006 12:28 schrieb Abdelrazak Younes: > Georg Baum wrote: > > Am Sonntag, 3. September 2006 12:11 schrieb Abdelrazak Younes: > >> This patch fixes the isDigit() MSVC warning in ControlSpellchecker.C. > > > > If that is really the correct isDigit() check for unciode > > My understanding is that ascii is a subset of ucs4 so it must work as is.
That is true, but the question is rather: For what purpose is isDigits used? Shall it be true for digits in other scripts, or are ASCII digits enough? I don't know. > > then you simply > > could have changed the argument type of the existing function. > > > > I did not touch this on purpose because of the FIXME comment... > > So why not changing all the methods in textutils.h instead? Because it is not that easy. E.g. isPrintable() is clearly wrong now (it was already wrong for e.g. latin1). > Most of our > use are unicode anyway. Yes, but I'd rather try to get rid of things like isLetterChar etc. These do not really make sense with unicode anymore. Georg
