Lars Gullik Bjønnes wrote:
Abdelrazak Younes <[EMAIL PROTECTED]> writes:
| Jean-Marc Lasgouttes wrote:
| >>>>>> "Abdelrazak" == Abdelrazak Younes <[EMAIL PROTECTED]> writes:
| > Abdelrazak> This patch moves the dialogs hidding/update from
| > Abdelrazak> BufferView. Will commit soon.
| > Looks good. Lots of small things to move around...
|
| Yes. Next target is the menuInsertLyXFile() which should not call any
| dialog.
|
| Also the track change dialog call should disappear from BufferView.
| Michael when are planning to merge your branch? I guess now is as good
| as ever as the trunk is broken with unicode anyway...
You mean it is wise to apply a possibly broken patch on top of
something you aready know to be broken?
No, I mean that it is OK to accept a potentially slightly broken feature
as this feature is broken in trunk anyway. As nobody can use trunk for
serious work anyway having a semi-broken track-change is not going to
harm anyone.
And as far as I know, the clean up work done that Michael has done
cannot not be called a broken patch.
Abdel.