a) this is a file format change, so it must not go to 1.4.x and needs
lyx2lyx support for 1.5. BTW, does 1.3.x have the same problem? If not,
then this is not a file format change but a bug and should be correct ASAP.

I can not test for 1.3.x, but the source code shows that it did not
have the comment environment support, only the lyx-comment which does
not output anything to latex.  see
http://www.lyx.org/trac/browser/lyx-devel/tags/lyx-1_3_7/src/insets/insetnote.h

Since the patch only touches lyx->latex output, I do not think this
changes lyx2lyx.

b) Does "\end{comment}{} b" work? That would be more elegant.

Thank you! {} works, and is of course more elegant than \vpsace{0in}.
An updated patch is attached. Can I apply this to the trunk? Could you
please confirm http://bugzilla.lyx.org/show_bug.cgi?id=2689 and set
its target to maybe 1.4.3?

Cheers,
Bo

Index: src/insets/insetnote.C
===================================================================
--- src/insets/insetnote.C      (revision 14481)
+++ src/insets/insetnote.C      (working copy)
@@ -266,6 +266,19 @@
       ss << "%\n\\begin{" << type << "}\n";
       InsetText::latex(buf, ss, runparams);
       ss << "%\n\\end{" << type << "}\n";
+       // the space after the comment in 'a[comment] b' will be eaten by the
+       // comment environment since the space before b is ignored with the
+       // following latex output:
+       //
+       // a%
+       // \begin{comment}
+       // comment%
+       // \end{comment}
+       //  b
+       //
+       // Adding {} before ' b' fixes this.
+       if  (params_.type == InsetNoteParams::Comment)
+               ss << "{}";

       string const str = ss.str();
       os << str;

Reply via email to