Bo Peng wrote:
>> a) this is a file format change, so it must not go to 1.4.x and needs
>> lyx2lyx support for 1.5. BTW, does 1.3.x have the same problem? If not,
>> then this is not a file format change but a bug and should be correct
>> ASAP.
>
> I can not test for 1.3.x, but the source code shows that it did not
> have the comment environment support, only the lyx-comment which does
> not output anything to latex. see
>
http://www.lyx.org/trac/browser/lyx-devel/tags/lyx-1_3_7/src/insets/insetnote.h
I just tried: 1.3.x has the comment layout, but since you can apply layouts
only paragraph-wise it does not have the space problem.
> Since the patch only touches lyx->latex output, I do not think this
> changes lyx2lyx.
We have two possibilities:
1) (what you want): Declare that it was never intended to swallow the space.
Then the current behaviour is buggy. We are going to fix it and tell users
"Sorry, but we fixed a bug that might change the output of your documents
if you use comments".
2) (what I think is correct): Realize that the current behaviour is a
mistake, but acknowledge that it is like that and implement the new
behaviour with a file format change and lyx2lyx support. Then the existing
documents will continue to produce the same output. This is IMO right,
since I would be very upset if an upgrade from 1.4.2 to 1.4.3 would
rearrange the output of e.g. a carefully crafted book.
Please don't commit anything until Jean-Marc is back. If he accepts 1) the
patch can go both in 1.4 and trunk, but if he does not we should change the
file format in trunk at the same time when the patch goes in.
BTW, did you check what happens to the other note environments? Maybe it is
even better to remove the offending % and output \end{...} at the end of
the previous line?
>> b) Does "\end{comment}{} b" work? That would be more elegant.
>
> Thank you! {} works, and is of course more elegant than \vpsace{0in}.
> An updated patch is attached. Can I apply this to the trunk? Could you
> please confirm http://bugzilla.lyx.org/show_bug.cgi?id=2689 and set
> its target to maybe 1.4.3?
I confirmed the bug (please ask Jean-Marc that he sets the confirm bit on
your bugzilla account when he is back).
Georg
