Abdelrazak Younes wrote:

> Because this change will have to be done on all qt code and the
> resulting patch will be bigger than this one. IMO, those changes are
> really minimal, nothing to fuss about.

Well, you see that they create fuss, so why not solve the problem once and
forever?
Nobody would look at such a mechanical patch. When you say "I am only going
to replace emit by QEMIT all over in qt4" everybody would trust you that
you would not do anything else.

> Oups, right, tanks, I'll change that. Who is responsible for this
> commented out code anyway?

Alfredo according to svn blame. It would be good if you could figure out
whether it can be deleted or reactivated.


Georg

Reply via email to