Abdelrazak Younes wrote: > Angus Leeming wrote: >> Georg Baum <[EMAIL PROTECTED]> writes: >>>> - return provides_ & p; >>>> + return (provides_ & p) != 0; >>>> } >> >>> I have the feeling that you will get objections for things like this >>> from others. >> >> Ceratinly, it seems unncesessary. C++ (unlike C#) has an implicit cast >> from int >> to bool. Is this MSVC complaining? (Not that that's a bad thing; we >> tend to be a >> little g++-centric for obvious reasons.) > > Yes, it's MSVC. It's a performance warning about possibly loosing > precision due to the automatic cast. You can get rid of the warning via > an explicit cast. > > + return bool(provides_ & p);
Yes, that's a better solution. (the warning was: ..\..\lyx-devel\src\lyxtextclass.C(1065) : warning C4800: 'int' : forcing value to bool 'true' or 'false' (performance warning) )
