Georg Baum <[EMAIL PROTECTED]> writes: > > + return deplist.size() != 0; > > We use > + return !deplist.empty(); > all over the place.
Right. And using "empty()" is often much faster than "size() != 0", so it's a good habbit to get into. > > - return provides_ & p; > > + return (provides_ & p) != 0; > > } > I have the feeling that you will get objections for things like this from > others. Ceratinly, it seems unncesessary. C++ (unlike C#) has an implicit cast from int to bool. Is this MSVC complaining? (Not that that's a bad thing; we tend to be a little g++-centric for obvious reasons.) Angus
