Georg Baum wrote:
Am Samstag, 3. Juni 2006 18:49 schrieb Abdelrazak Younes:
Hello,

This patch works fine under windows. Georg, Bennett could you please check that it works fine on your respective platform.

It does work fine, but I needed two fixes to compile:

- #include "BufferView.h" in Application.C
- add a semicolon after the declaration of QWorkArea::inputMethodEvent (and the extra QWorkarea qualification will not work with gcc 4.1 and newer).

Corrected thanks. The doxygen comments are OK also.

I thought this qt-immodule thing was a Qt3 only thing. I was wrong apparently... care to explain me in a few words what this is about?

So how do we proceed? I see that you have other changes to QWorkArea and I fear that our two versions will diverge. So I guess one should commit ASAP.

Your changes are more intrusive than mine so I guess my patch should go first. The fact that I am lazy is an important factor also ;-). But you can convince me to wait if you feel it's better.

Just tell me what you think.
Abdel.

Reply via email to