Jean-Marc Lasgouttes a écrit :
"Abdelrazak" == Abdelrazak Younes <[EMAIL PROTECTED]> writes:

It is indeed late for 1.4.1, but it will definitely go in 1.4.2.

Abdelrazak> OK, then please note that there are a number of other
Abdelrazak> calls to updateCounters that can be optimized also but I
Abdelrazak> did not have the time to test them extensively.
Abdelrazak> setLayout() is a good candidate for example. I don't have
Abdelrazak> a local repository for 1.4 so I'll let you manage that.
Abdelrazak> OK?

I'll see what I can do.
OK, thanks.

BTW, do you really need the default: case in your switch? It is
better to avoid them in general...

Abdelrazak> What if there is a new kind of label that is not listed
Abdelrazak> here?

You get a compiler warning and you fix it.
What if the compiler warning goes unnoticed? I really prefer to use "default" in this case because by default it will do the full counter update.

Abdel.


Reply via email to