Georg Baum a écrit :
Abdelrazak Younes wrote:

Jean-Marc Lasgouttes a écrit :
What if the compiler warning goes unnoticed?

Thou shalt always listen to your compiler!

I always do, don't worry. I was not talking about me :-)

I really prefer to use "default" in this case because by default it will do the full counter
update.

Have you never been bitten by the problem that you introduced a new enum
member that was handled by the default case where it should have been
treated specially? I have, and more than once.

Sure in the general case I agree with you, but in this case, it is better to do the full update if you don't know about the label types. The label types are enumerated here in order to remind us that they could do with an optimization. Otherwise I would have checked only the label types I am concerned with.
But, as it seems to be a religious matter :-), I will remove the default.

Abdel.

Reply via email to